ocfs2: fix an off-by-one BUG_ON() statement

The ->si_slots[] array is allocated in ocfs2_init_slot_info() it has
"->max_slots" number of elements so this test should be >= instead of >.

Static checker work.  Compile tested only.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Mark Fasheh <mfasheh@suse.com>
Cc: Joel Becker <jlbec@evilplan.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

diff --git a/fs/ocfs2/slot_map.c b/fs/ocfs2/slot_map.c
index a88b2a4fcc85171210cd17f8e4f9a791d5aa1d2b..d5493e361a381b12a9d57a779294fb172fb963b3 100644 (file)
--- a/fs/ocfs2/slot_map.c
+++ b/fs/ocfs2/slot_map.c
@@ -306,7 +306,7 @@ int ocfs2_slot_to_node_num_locked(struct ocfs2_super *osb, int slot_num,
        assert_spin_locked(&osb->osb_lock);
 
        BUG_ON(slot_num < 0);
-       BUG_ON(slot_num > osb->max_slots);
+       BUG_ON(slot_num >= osb->max_slots);
 
        if (!si->si_slots[slot_num].sl_valid)
                return -ENOENT;