]> git.baikalelectronics.ru Git - kernel.git/commitdiff
iio: adc: ad7476: remove redundant null check on an array
authorColin Ian King <colin.king@canonical.com>
Fri, 24 Apr 2020 13:04:19 +0000 (14:04 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 3 May 2020 08:47:21 +0000 (09:47 +0100)
The null check on st->chip_info->convst_channel is redundant because
convst_channel is a 2 element array of struct iio_chan_spec objects
and this can never be null. Fix this by removing the null check.

Addresses-Coverity: ("Array compared against 0")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/ad7476.c

index e9984a38fc4c5d821f111674946ed35f2770deab..4e816d714ad217446bec4c48bf8692318d754cd4 100644 (file)
@@ -309,7 +309,7 @@ static int ad7476_probe(struct spi_device *spi)
        indio_dev->num_channels = 2;
        indio_dev->info = &ad7476_info;
 
-       if (st->convst_gpio && st->chip_info->convst_channel)
+       if (st->convst_gpio)
                indio_dev->channels = st->chip_info->convst_channel;
        /* Setup default message */