]> git.baikalelectronics.ru Git - kernel.git/commitdiff
libnvdimm, pmem: fix size trim in pmem_direct_access()
authorDan Williams <dan.j.williams@intel.com>
Sun, 25 Oct 2015 02:55:58 +0000 (19:55 -0700)
committerDan Williams <dan.j.williams@intel.com>
Thu, 12 Nov 2015 17:55:23 +0000 (09:55 -0800)
This masking prevents access to the end of the device via dax_do_io(),
and is unnecessary as arch_add_memory() would have rejected an unaligned
allocation.

Cc: <stable@vger.kernel.org>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
drivers/nvdimm/pmem.c

index 012e0649f1ac48374de47a690a2d0ac1d1865cac..8ee79893d2f5f6f5165558baa22f236738b99c45 100644 (file)
@@ -105,22 +105,11 @@ static long pmem_direct_access(struct block_device *bdev, sector_t sector,
 {
        struct pmem_device *pmem = bdev->bd_disk->private_data;
        resource_size_t offset = sector * 512 + pmem->data_offset;
-       resource_size_t size;
-
-       if (pmem->data_offset) {
-               /*
-                * Limit the direct_access() size to what is covered by
-                * the memmap
-                */
-               size = (pmem->size - offset) & ~ND_PFN_MASK;
-       } else
-               size = pmem->size - offset;
-
-       /* FIXME convert DAX to comprehend that this mapping has a lifetime */
+
        *kaddr = pmem->virt_addr + offset;
        *pfn = (pmem->phys_addr + offset) >> PAGE_SHIFT;
 
-       return size;
+       return pmem->size - offset;
 }
 
 static const struct block_device_operations pmem_fops = {