]> git.baikalelectronics.ru Git - kernel.git/commitdiff
MIPS: SEAD-3: Fix GIC interrupt specifiers
authorPaul Burton <paul.burton@imgtec.com>
Fri, 2 Jun 2017 19:29:59 +0000 (12:29 -0700)
committerRalf Baechle <ralf@linux-mips.org>
Wed, 28 Jun 2017 10:22:42 +0000 (12:22 +0200)
The various interrupt specifiers in the device tree are not in a valid
format for the MIPS GIC interrupt controller binding. Where each
interrupt should provide 3 values - GIC_LOCAL or GIC_SHARED, the
pin number & the type of interrupt - the device tree was only providing
the pin number. This causes interrupts for those devices to not be used
when a GIC is present. SEAD-3 systems without a GIC are unaffected since
the DT fixup code generates interrupt specifiers that are valid for the
CPU interrupt controller.

Fix this by adding the GIC_SHARED & IRQ_TYPE_LEVEL_HIGH values to each
interrupt specifier.

Signed-off-by: Paul Burton <paul.burton@imgtec.com>
Fixes: c11e3b48dbc3 ("MIPS: SEAD3: Probe UARTs using DT")
Fixes: a34e93882de4 ("MIPS: SEAD3: Probe ethernet controller using DT")
Fixes: 7afd2a5aec2e ("MIPS: SEAD3: Probe EHCI controller using DT")
Cc: linux-mips@linux-mips.org
Cc: stable@vger.kernel.org # v4.9+
Patchwork: https://patchwork.linux-mips.org/patch/16189/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
arch/mips/boot/dts/mti/sead3.dts

index cabe256f9a68419813c6adef5be1df584302974c..4f8bc83c296057a7bd4b0a9c6d7e59f44b5c7ff0 100644 (file)
@@ -60,7 +60,7 @@
                reg = <0x1b200000 0x1000>;
 
                interrupt-parent = <&gic>;
-               interrupts = <0>; /* GIC 0 or CPU 6 */
+               interrupts = <GIC_SHARED 0 IRQ_TYPE_LEVEL_HIGH>; /* GIC 0 or CPU 6 */
 
                has-transaction-translator;
        };
                clock-frequency = <14745600>;
 
                interrupt-parent = <&gic>;
-               interrupts = <3>; /* GIC 3 or CPU 4 */
+               interrupts = <GIC_SHARED 3 IRQ_TYPE_LEVEL_HIGH>; /* GIC 3 or CPU 4 */
 
                no-loopback-test;
        };
                clock-frequency = <14745600>;
 
                interrupt-parent = <&gic>;
-               interrupts = <2>; /* GIC 2 or CPU 4 */
+               interrupts = <GIC_SHARED 2 IRQ_TYPE_LEVEL_HIGH>; /* GIC 2 or CPU 4 */
 
                no-loopback-test;
        };
                reg-io-width = <4>;
 
                interrupt-parent = <&gic>;
-               interrupts = <0>; /* GIC 0 or CPU 6 */
+               interrupts = <GIC_SHARED 0 IRQ_TYPE_LEVEL_HIGH>; /* GIC 0 or CPU 6 */
 
                phy-mode = "mii";
                smsc,irq-push-pull;