block: simplify blktrace sysfs attribute creation

Add the trace attributes to the default gendisk attributes, just like
we already do for partitions.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20220628171850.1313069-2-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>

diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c
index 9b211e519de81c7ce681e45b54df059aad489d55..5f3f73115988cf8e9d35e5085dfb379842e4958d 100644 (file)
--- a/block/blk-sysfs.c
+++ b/block/blk-sysfs.c
@@ -810,21 +810,14 @@ int blk_register_queue(struct gendisk *disk)
        struct device *dev = disk_to_dev(disk);
        struct request_queue *q = disk->queue;
 
-       ret = blk_trace_init_sysfs(dev);
-       if (ret)
-               return ret;
-
        mutex_lock(&q->sysfs_dir_lock);
 
        ret = kobject_add(&q->kobj, kobject_get(&dev->kobj), "%s", "queue");
-       if (ret < 0) {
-               blk_trace_remove_sysfs(dev);
+       if (ret < 0)
                goto unlock;
-       }
 
        ret = sysfs_create_group(&q->kobj, &queue_attr_group);
        if (ret) {
-               blk_trace_remove_sysfs(dev);
                kobject_del(&q->kobj);
                kobject_put(&dev->kobj);
                goto unlock;
@@ -890,7 +883,6 @@ put_dev:
        mutex_unlock(&q->sysfs_lock);
        mutex_unlock(&q->sysfs_dir_lock);
        kobject_del(&q->kobj);
-       blk_trace_remove_sysfs(dev);
        kobject_put(&dev->kobj);
 
        return ret;
@@ -931,7 +923,6 @@ void blk_unregister_queue(struct gendisk *disk)
        if (queue_is_mq(q))
                blk_mq_unregister_dev(disk_to_dev(disk), q);
        blk_crypto_sysfs_unregister(q);
-       blk_trace_remove_sysfs(disk_to_dev(disk));
 
        mutex_lock(&q->sysfs_lock);
        elv_unregister_queue(q);

diff --git a/block/blk.h b/block/blk.h
index 1a0d3e6a4a6313c3b6203f36a10015b518592f29..74d59435870cb5aebfda2882b3325a77f79a82ab 100644 (file)
--- a/block/blk.h
+++ b/block/blk.h
@@ -452,6 +452,8 @@ extern struct device_attribute dev_attr_events;
 extern struct device_attribute dev_attr_events_async;
 extern struct device_attribute dev_attr_events_poll_msecs;
 
+extern struct attribute_group blk_trace_attr_group;
+
 long blkdev_ioctl(struct file *file, unsigned cmd, unsigned long arg);
 long compat_blkdev_ioctl(struct file *file, unsigned cmd, unsigned long arg);
 

diff --git a/block/genhd.c b/block/genhd.c
index bf9be06af2c8da3175865cd5bd15e291124bb699..b1fb7e058b9cc51d31093e90accff5760182c435 100644 (file)
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -1134,6 +1134,9 @@ static struct attribute_group disk_attr_group = {
 
 static const struct attribute_group *disk_attr_groups[] = {
        &disk_attr_group,
+#ifdef CONFIG_BLK_DEV_IO_TRACE
+       &blk_trace_attr_group,
+#endif
        NULL
 };
 

diff --git a/block/partitions/core.c b/block/partitions/core.c
index 8a0ec929023bcd2ded0579194d99a1044bc7cb6d..7dc487f5b03cd600f25dbed9e3baffa53a888716 100644 (file)
--- a/block/partitions/core.c
+++ b/block/partitions/core.c
@@ -9,7 +9,6 @@
 #include <linux/slab.h>
 #include <linux/ctype.h>
 #include <linux/vmalloc.h>
-#include <linux/blktrace_api.h>
 #include <linux/raid/detect.h>
 #include "check.h"
 

diff --git a/include/linux/blktrace_api.h b/include/linux/blktrace_api.h
index 623e22492afa50de750593485e0e264519c44779..f6f9b544365ab2ffff3ca6e04fbcfec80ffb698f 100644 (file)
--- a/include/linux/blktrace_api.h
+++ b/include/linux/blktrace_api.h
@@ -77,10 +77,6 @@ extern int blk_trace_setup(struct request_queue *q, char *name, dev_t dev,
                           char __user *arg);
 extern int blk_trace_startstop(struct request_queue *q, int start);
 extern int blk_trace_remove(struct request_queue *q);
-extern void blk_trace_remove_sysfs(struct device *dev);
-extern int blk_trace_init_sysfs(struct device *dev);
-
-extern struct attribute_group blk_trace_attr_group;
 
 #else /* !CONFIG_BLK_DEV_IO_TRACE */
 # define blk_trace_ioctl(bdev, cmd, arg)               (-ENOTTY)
@@ -91,13 +87,7 @@ extern struct attribute_group blk_trace_attr_group;
 # define blk_trace_remove(q)                           (-ENOTTY)
 # define blk_add_trace_msg(q, fmt, ...)                        do { } while (0)
 # define blk_add_cgroup_trace_msg(q, cg, fmt, ...)     do { } while (0)
-# define blk_trace_remove_sysfs(dev)                   do { } while (0)
 # define blk_trace_note_message_enabled(q)             (false)
-static inline int blk_trace_init_sysfs(struct device *dev)
-{
-       return 0;
-}
-
 #endif /* CONFIG_BLK_DEV_IO_TRACE */
 
 #ifdef CONFIG_COMPAT

diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
index fe04c6f96ca5d04b86ac5468dfc7750cc2ff110c..c584effe5fe99285092a6ae1cd54d18fe870829f 100644 (file)
--- a/kernel/trace/blktrace.c
+++ b/kernel/trace/blktrace.c
@@ -1867,17 +1867,6 @@ out_unlock_bdev:
 out:
        return ret ? ret : count;
 }
-
-int blk_trace_init_sysfs(struct device *dev)
-{
-       return sysfs_create_group(&dev->kobj, &blk_trace_attr_group);
-}
-
-void blk_trace_remove_sysfs(struct device *dev)
-{
-       sysfs_remove_group(&dev->kobj, &blk_trace_attr_group);
-}
-
 #endif /* CONFIG_BLK_DEV_IO_TRACE */
 
 #ifdef CONFIG_EVENT_TRACING