]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net: qrtr: revert check in qrtr_endpoint_post()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 2 Sep 2021 10:08:51 +0000 (13:08 +0300)
committerDavid S. Miller <davem@davemloft.net>
Thu, 2 Sep 2021 10:37:02 +0000 (11:37 +0100)
I tried to make this check stricter as a hardenning measure but it broke
audo and wifi on these devices so revert it.

Fixes: aaa8e4922c88 ("net: qrtr: make checks in qrtr_endpoint_post() stricter")
Reported-by: John Stultz <john.stultz@linaro.org>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Tested-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/qrtr/qrtr.c

index 525e3ea063b143177c8393dd5921d88259d6896b..ec2322529727820d60e1fa13e1422d6ed8431608 100644 (file)
@@ -493,7 +493,7 @@ int qrtr_endpoint_post(struct qrtr_endpoint *ep, const void *data, size_t len)
                goto err;
        }
 
-       if (!size || size & 3 || len != size + hdrlen)
+       if (!size || len != ALIGN(size, 4) + hdrlen)
                goto err;
 
        if (cb->dst_port != QRTR_PORT_CTRL && cb->type != QRTR_TYPE_DATA &&