]> git.baikalelectronics.ru Git - kernel.git/commitdiff
openrisc: Fix issue with argument clobbering for clone/fork
authorStafford Horne <shorne@gmail.com>
Wed, 22 Apr 2020 11:24:11 +0000 (20:24 +0900)
committerStafford Horne <shorne@gmail.com>
Sun, 31 May 2020 21:15:32 +0000 (06:15 +0900)
Working on the OpenRISC glibc port I found that sometimes clone was
working strange.  That the tls data argument sent in r7 was always
wrong.  Further investigation revealed that the arguments were getting
clobbered in the entry code.  This patch removes the code that writes to
the argument registers.  This was likely due to some old code hanging
around.

This patch fixes this up for clone and fork.  This fork clobber is
harmless but also useless so remove.

Signed-off-by: Stafford Horne <shorne@gmail.com>
arch/openrisc/kernel/entry.S

index e4a78571f88335e92398c655e3bb402528d04576..c6481cfc5220f841b2d0cecdd4168502784a5919 100644 (file)
@@ -1166,13 +1166,13 @@ ENTRY(__sys_clone)
        l.movhi r29,hi(sys_clone)
        l.ori   r29,r29,lo(sys_clone)
        l.j     _fork_save_extra_regs_and_call
-        l.addi r7,r1,0
+        l.nop
 
 ENTRY(__sys_fork)
        l.movhi r29,hi(sys_fork)
        l.ori   r29,r29,lo(sys_fork)
        l.j     _fork_save_extra_regs_and_call
-        l.addi r3,r1,0
+        l.nop
 
 ENTRY(sys_rt_sigreturn)
        l.jal   _sys_rt_sigreturn