]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net: hns3: refactor hclge_config_tso()
authorHuazhong Tan <tanhuazhong@huawei.com>
Thu, 28 May 2020 13:48:10 +0000 (21:48 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 28 May 2020 23:39:03 +0000 (16:39 -0700)
Since parameters 'tso_mss_min' and 'tso_mss_max' only indicate
the minimum and maximum MSS, the hnae3_set_field() calls are
meaningless, remove them and change the type of these two
parameters to u16.

Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

index 7d5c304bd6b135e03f333190032234f3d5e4b083..35e5cb87f48c59e83eca5d43f9465b21299fadae 100644 (file)
@@ -1429,26 +1429,17 @@ static int hclge_configure(struct hclge_dev *hdev)
        return ret;
 }
 
-static int hclge_config_tso(struct hclge_dev *hdev, unsigned int tso_mss_min,
-                           unsigned int tso_mss_max)
+static int hclge_config_tso(struct hclge_dev *hdev, u16 tso_mss_min,
+                           u16 tso_mss_max)
 {
        struct hclge_cfg_tso_status_cmd *req;
        struct hclge_desc desc;
-       u16 tso_mss;
 
        hclge_cmd_setup_basic_desc(&desc, HCLGE_OPC_TSO_GENERIC_CONFIG, false);
 
        req = (struct hclge_cfg_tso_status_cmd *)desc.data;
-
-       tso_mss = 0;
-       hnae3_set_field(tso_mss, HCLGE_TSO_MSS_MIN_M,
-                       HCLGE_TSO_MSS_MIN_S, tso_mss_min);
-       req->tso_mss_min = cpu_to_le16(tso_mss);
-
-       tso_mss = 0;
-       hnae3_set_field(tso_mss, HCLGE_TSO_MSS_MIN_M,
-                       HCLGE_TSO_MSS_MIN_S, tso_mss_max);
-       req->tso_mss_max = cpu_to_le16(tso_mss);
+       req->tso_mss_min = cpu_to_le16(tso_mss_min);
+       req->tso_mss_max = cpu_to_le16(tso_mss_max);
 
        return hclge_cmd_send(&hdev->hw, &desc, 1);
 }