The "fid" variable can't be an error pointer so there is no need to
check. The code is slightly cleaner if we move the increment before
the break and remove the NULL check as well.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>
h = (struct hlist_head *)&inode->i_private;
hlist_for_each_entry(fid, h, ilist) {
if (uid_eq(fid->uid, uid)) {
+ refcount_inc(&fid->count);
ret = fid;
break;
}
}
- if (ret && !IS_ERR(ret))
- refcount_inc(&ret->count);
spin_unlock(&inode->i_lock);
return ret;
}