]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net: dsa: microchip: Fix ksz_read64()
authorBen Hutchings <ben.hutchings@mind.be>
Mon, 9 Aug 2021 22:59:12 +0000 (00:59 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 10 Aug 2021 08:58:14 +0000 (09:58 +0100)
ksz_read64() currently does some dubious byte-swapping on the two
halves of a 64-bit register, and then only returns the high bits.
Replace this with a straightforward expression.

Fixes: f43f531406fa ("net: dsa: ksz: Add Microchip KSZ8795 DSA driver")
Signed-off-by: Ben Hutchings <ben.hutchings@mind.be>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/microchip/ksz_common.h

index 2e6bfd333f504c9a1dd2490a5d41440175d70bba..6afbb41ad39e3abb2658bd721e8c85ddff806f7a 100644 (file)
@@ -205,12 +205,8 @@ static inline int ksz_read64(struct ksz_device *dev, u32 reg, u64 *val)
        int ret;
 
        ret = regmap_bulk_read(dev->regmap[2], reg, value, 2);
-       if (!ret) {
-               /* Ick! ToDo: Add 64bit R/W to regmap on 32bit systems */
-               value[0] = swab32(value[0]);
-               value[1] = swab32(value[1]);
-               *val = swab64((u64)*value);
-       }
+       if (!ret)
+               *val = (u64)value[0] << 32 | value[1];
 
        return ret;
 }