]> git.baikalelectronics.ru Git - kernel.git/commitdiff
staging: wfx: drop useless update of field basic_rate_set
authorJérôme Pouiller <jerome.pouiller@silabs.com>
Mon, 20 Apr 2020 16:03:04 +0000 (18:03 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 23 Apr 2020 11:26:04 +0000 (13:26 +0200)
Basic Rates are already set by hif_join(). hif_join() is also able to
manage possible changes after association.

Firmware also allows to change the Basic Rates with
hif_set_association_mode() but it does not bring anything in our case.

Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
Link: https://lore.kernel.org/r/20200420160311.57323-10-Jerome.Pouiller@silabs.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wfx/hif_tx_mib.c

index f04116ecb373078772947343b82f2c878210c793..16f4908055afadee528ae5e5cbe4e5dce7e9e498 100644 (file)
@@ -190,15 +190,12 @@ int hif_set_block_ack_policy(struct wfx_vif *wvif,
 int hif_set_association_mode(struct wfx_vif *wvif,
                             struct ieee80211_bss_conf *info)
 {
-       int basic_rates = wfx_rate_mask_to_hw(wvif->wdev, info->basic_rates);
        struct ieee80211_sta *sta = NULL;
        struct hif_mib_set_association_mode val = {
                .preambtype_use = 1,
                .mode = 1,
-               .rateset = 1,
                .spacing = 1,
                .short_preamble = info->use_short_preamble,
-               .basic_rate_set = cpu_to_le32(basic_rates)
        };
 
        rcu_read_lock(); // protect sta