]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net: allwinner: Fix print format
authorJakub Kicinski <kuba@kernel.org>
Sat, 8 Jan 2022 03:44:38 +0000 (19:44 -0800)
committerJakub Kicinski <kuba@kernel.org>
Mon, 10 Jan 2022 00:52:12 +0000 (16:52 -0800)
Kees reports quoted commit introduced the following warning on arm64:

drivers/net/ethernet/allwinner/sun4i-emac.c:922:60: error: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'resource_size_t' {aka 'long long unsigned int'} [-Werror=format=]
  922 |         netdev_info(ndev, "get io resource from device: 0x%x, size = %u\n",
      |                                                           ~^
      |                                                            |                                      |                                                            unsigned int
      |                                                           %llx
  923 |                     regs->start, resource_size(regs));
      |                     ~~~~~~~~~~~
      |                         |
      |                         resource_size_t {aka long long unsigned int}

.. and another one like that for resource_size().

Switch to %pa and a cast.

Reported-by: Kees Cook <keescook@chromium.org>
Fixes: 1906214e8ba3 ("sun4i-emac.c: add dma support")
Link: https://lore.kernel.org/r/20220108034438.2227343-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/allwinner/sun4i-emac.c

index 964227e342ee1600ea8c39bd4e6dc1e454c3f0d1..849de45647099c708abd21c9e0a270250d4b355a 100644 (file)
@@ -919,8 +919,8 @@ static int emac_configure_dma(struct emac_board_info *db)
                goto out_clear_chan;
        }
 
-       netdev_info(ndev, "get io resource from device: 0x%x, size = %u\n",
-                   regs->start, resource_size(regs));
+       netdev_info(ndev, "get io resource from device: %pa, size = %u\n",
+                   &regs->start, (unsigned int)resource_size(regs));
        db->emac_rx_fifo = regs->start + EMAC_RX_IO_DATA_REG;
 
        db->rx_chan = dma_request_chan(&pdev->dev, "rx");