env: mmc: Fix offset issue for env save

Fix the issue in commit 591dbad ("env: mcc: Drop unnecessary #ifdefs")
If CONFIG_SYS_REDUNDAND_ENVIRONMENT is not defined, the offset value
becomes undetermined, so write env to unexpected offset.

Signed-off-by: Ye Li <ye.li@nxp.com>
Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>

diff --git a/env/mmc.c b/env/mmc.c
index 85761417f2836ca57b3e9516c892c69ab1c54661..5b01f657a7a14a76cf206ec3309f49aa830c5775 100644 (file)
--- a/env/mmc.c
+++ b/env/mmc.c
@@ -273,11 +273,11 @@ static int env_mmc_save(void)
                        if (ret)
                                goto fini;
                }
+       }
 
-               if (mmc_get_env_addr(mmc, copy, &offset)) {
-                       ret = 1;
-                       goto fini;
-               }
+       if (mmc_get_env_addr(mmc, copy, &offset)) {
+               ret = 1;
+               goto fini;
        }
 
        printf("Writing to %sMMC(%d)... ", copy ? "redundant " : "", dev);