]> git.baikalelectronics.ru Git - kernel.git/commitdiff
scsi: ufs: ufs-qcom: Remove unneeded code
authorChanWoo Lee <cw9316.lee@samsung.com>
Mon, 27 Jun 2022 23:55:45 +0000 (08:55 +0900)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 28 Jun 2022 03:20:16 +0000 (23:20 -0400)
Checks information about tx_lanes, but is not used.

Since commit 8a47c02a5c4b ("scsi/ufs: qcom: Remove ufs_qcom_phy_*() calls
from host"), tx_lanes is deprecated.

As a result, ufs_qcom_link_startup_notify -> POST_CHANGE action does
nothing.  If it is not going to be updated, it can be removed.

Link: https://lore.kernel.org/r/20220627235545.16943-1-cw9316.lee@samsung.com
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: ChanWoo Lee <cw9316.lee@samsung.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/ufs/host/ufs-qcom.c

index f10d4668814cc35e07c1b2a858f61f40440c23ca..473fad83701ea8e3153726d4816f1cb6b9406c75 100644 (file)
@@ -58,19 +58,6 @@ static void ufs_qcom_dump_regs_wrapper(struct ufs_hba *hba, int offset, int len,
        ufshcd_dump_regs(hba, offset, len * 4, prefix);
 }
 
-static int ufs_qcom_get_connected_tx_lanes(struct ufs_hba *hba, u32 *tx_lanes)
-{
-       int err = 0;
-
-       err = ufshcd_dme_get(hba,
-                       UIC_ARG_MIB(PA_CONNECTEDTXDATALANES), tx_lanes);
-       if (err)
-               dev_err(hba->dev, "%s: couldn't read PA_CONNECTEDTXDATALANES %d\n",
-                               __func__, err);
-
-       return err;
-}
-
 static int ufs_qcom_host_clk_get(struct device *dev,
                const char *name, struct clk **clk_out, bool optional)
 {
@@ -194,13 +181,6 @@ out:
        return err;
 }
 
-static int ufs_qcom_link_startup_post_change(struct ufs_hba *hba)
-{
-       u32 tx_lanes;
-
-       return ufs_qcom_get_connected_tx_lanes(hba, &tx_lanes);
-}
-
 static int ufs_qcom_check_hibern8(struct ufs_hba *hba)
 {
        int err;
@@ -569,9 +549,6 @@ static int ufs_qcom_link_startup_notify(struct ufs_hba *hba,
                if (ufshcd_get_local_unipro_ver(hba) != UFS_UNIPRO_VER_1_41)
                        err = ufshcd_disable_host_tx_lcc(hba);
 
-               break;
-       case POST_CHANGE:
-               ufs_qcom_link_startup_post_change(hba);
                break;
        default:
                break;