]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net: fec_ptp: add clock rate zero check
authorFugang Duan <fugang.duan@nxp.com>
Wed, 16 Jun 2021 09:14:25 +0000 (17:14 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 16 Jun 2021 19:39:03 +0000 (12:39 -0700)
Add clock rate zero check to fix coverity issue of "divide by 0".

Fixes: commit 85bd1798b24a ("net: fec: fix spin_lock dead lock")
Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/fec_ptp.c

index 1753807cbf97e2bff83a218a8ba33f662fe593b7..7326a0612823869daeda2782639aa2f63df5520a 100644 (file)
@@ -604,6 +604,10 @@ void fec_ptp_init(struct platform_device *pdev, int irq_idx)
        fep->ptp_caps.enable = fec_ptp_enable;
 
        fep->cycle_speed = clk_get_rate(fep->clk_ptp);
+       if (!fep->cycle_speed) {
+               fep->cycle_speed = NSEC_PER_SEC;
+               dev_err(&fep->pdev->dev, "clk_ptp clock rate is zero\n");
+       }
        fep->ptp_inc = NSEC_PER_SEC / fep->cycle_speed;
 
        spin_lock_init(&fep->tmreg_lock);