]> git.baikalelectronics.ru Git - kernel.git/commitdiff
rtw88: Fix an error code in rtw_debugfs_set_rsvd_page()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 15 Mar 2021 09:23:37 +0000 (12:23 +0300)
committerKalle Valo <kvalo@codeaurora.org>
Sun, 11 Apr 2021 09:29:06 +0000 (12:29 +0300)
The sscanf() function returns the number of matches (0 or 1 in this
case).  It doesn't return error codes.  We should return -EINVAL if the
string is invalid

Fixes: c376c1fc87b7 ("rtw88: add h2c command in debugfs")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/YE8nmatMDBDDWkjq@mwanda
drivers/net/wireless/realtek/rtw88/debug.c

index 4539b673f6fd41cb9292a6b19d15a1f5261497eb..5c44fa87ed2ec1a1556da7a108e360fa89c46eeb 100644 (file)
@@ -271,7 +271,7 @@ static ssize_t rtw_debugfs_set_rsvd_page(struct file *filp,
 
        if (num != 2) {
                rtw_warn(rtwdev, "invalid arguments\n");
-               return num;
+               return -EINVAL;
        }
 
        debugfs_priv->rsvd_page.page_offset = offset;