]> git.baikalelectronics.ru Git - kernel.git/commitdiff
Input: sparcspkr - fix refcount leak in bbc_beep_probe
authorMiaoqian Lin <linmq006@gmail.com>
Mon, 16 May 2022 21:55:55 +0000 (14:55 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 17 May 2022 04:10:11 +0000 (21:10 -0700)
of_find_node_by_path() calls of_find_node_opts_by_path(),
which returns a node pointer with refcount
incremented, we should use of_node_put() on it when done.
Add missing of_node_put() to avoid refcount leak.

Fixes: 9c1a5077fdca ("input: Rewrite sparcspkr device probing.")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220516081018.42728-1-linmq006@gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/misc/sparcspkr.c

index fe43e5557ed72b1b8b942b7a3b78d8807a700980..cdcb7737c46aa50a91d5205d8728f13f9d8215a1 100644 (file)
@@ -205,6 +205,7 @@ static int bbc_beep_probe(struct platform_device *op)
 
        info = &state->u.bbc;
        info->clock_freq = of_getintprop_default(dp, "clock-frequency", 0);
+       of_node_put(dp);
        if (!info->clock_freq)
                goto out_free;