powerpc/32: indirect function call use bctrl rather than blrl in ret_from_kernel_thread

Copied from commit 821868e38a76 ("powerpc/64: indirect function call
use bctrl rather than blrl in ret_from_kernel_thread")

blrl is not recommended to use as an indirect function call, as it may
corrupt the link stack predictor.

This is not a performance critical path but this should be fixed for
consistency.

Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/91b1d242525307ceceec7ef6e832bfbacdd4501b.1629436472.git.christophe.leroy@csgroup.eu

diff --git a/arch/powerpc/kernel/entry_32.S b/arch/powerpc/kernel/entry_32.S
index 0273a13490063ddba9305cbb7376d619aab4fe8f..61fdd53cdd9af1d74852c6497a3684c2c5d1c786 100644 (file)
--- a/arch/powerpc/kernel/entry_32.S
+++ b/arch/powerpc/kernel/entry_32.S
@@ -161,10 +161,10 @@ ret_from_fork:
 ret_from_kernel_thread:
        REST_NVGPRS(r1)
        bl      schedule_tail
-       mtlr    r14
+       mtctr   r14
        mr      r3,r15
        PPC440EP_ERR42
-       blrl
+       bctrl
        li      r3,0
        b       ret_from_syscall