]> git.baikalelectronics.ru Git - kernel.git/commitdiff
irqchip/ls-extirq: add IRQCHIP_SKIP_SET_WAKE to the irqchip flags
authorBiwen Li <biwen.li@nxp.com>
Fri, 29 Jan 2021 09:50:34 +0000 (17:50 +0800)
committerMarc Zyngier <maz@kernel.org>
Fri, 29 Jan 2021 11:06:38 +0000 (11:06 +0000)
The ls-extirq driver doesn't implement the irq_set_wake()
callback, while being wake-up capable. This results in
ugly behaviours across suspend/resume cycles.

Advertise this by adding IRQCHIP_SKIP_SET_WAKE to
the irqchip flags

Fixes: b16a1caf4686 ("irqchip/ls-extirq: Add LS1043A, LS1088A external interrupt support")
Signed-off-by: Biwen Li <biwen.li@nxp.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20210129095034.33821-1-biwen.li@oss.nxp.com
drivers/irqchip/irq-ls-extirq.c

index f94f974a8764527d75c646949adf87e4eb05f941..853b3972dbe7897c2c9f13d1437ab026a3faf0a3 100644 (file)
@@ -64,7 +64,7 @@ static struct irq_chip ls_extirq_chip = {
        .irq_set_type           = ls_extirq_set_type,
        .irq_retrigger          = irq_chip_retrigger_hierarchy,
        .irq_set_affinity       = irq_chip_set_affinity_parent,
-       .flags                  = IRQCHIP_SET_TYPE_MASKED,
+       .flags                  = IRQCHIP_SET_TYPE_MASKED | IRQCHIP_SKIP_SET_WAKE,
 };
 
 static int