]> git.baikalelectronics.ru Git - kernel.git/commitdiff
scsi: ufs: core: Fix divide by zero in ufshcd_map_queues()
authorJinyoung Choi <j-young.choi@samsung.com>
Mon, 14 Feb 2022 10:33:52 +0000 (19:33 +0900)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 15 Feb 2022 03:10:29 +0000 (22:10 -0500)
Before calling blk_mq_map_queues(), the mq_map and nr_queues belonging to
struct blk_mq_queue_map must have a valid value.

If nr_queues is set to 0, the system may encounter a divide by zero
depending on the type of architecture.

    blk_mq_map_queues() -> queue_index()

Link: https://lore.kernel.org/r/1891546521.01644873481638.JavaMail.epsvc@epcpadp4
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Jinyoung Choi <j-young.choi@samsung.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/ufs/ufshcd.c

index 50b12d60dc1b2deae027c1a476773fca56a6261a..9349557b8a01b44dd361025d36a845a291593c5a 100644 (file)
@@ -2681,7 +2681,7 @@ static int ufshcd_map_queues(struct Scsi_Host *shost)
                        break;
                case HCTX_TYPE_READ:
                        map->nr_queues = 0;
-                       break;
+                       continue;
                default:
                        WARN_ON_ONCE(true);
                }