]> git.baikalelectronics.ru Git - kernel.git/commitdiff
irqchip/loongson-pch-msi: Use bitmap_zalloc() to allocate bitmap
authorHuacai Chen <chenhuacai@loongson.cn>
Tue, 9 Feb 2021 07:10:51 +0000 (15:10 +0800)
committerMarc Zyngier <maz@kernel.org>
Tue, 9 Feb 2021 10:41:40 +0000 (10:41 +0000)
Currently we use bitmap_alloc() to allocate msi bitmap which should be
initialized with zero. This is obviously wrong but it works because msi
can fallback to legacy interrupt mode. So use bitmap_zalloc() instead.

Fixes: 632dcc2c75ef6de3272aa ("irqchip: Add Loongson PCH MSI controller")
Cc: stable@vger.kernel.org
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20210209071051.2078435-1-chenhuacai@loongson.cn
drivers/irqchip/irq-loongson-pch-msi.c

index 12aeeab4328939970747a9645d381f4672c46b73..32562b7e681b53ade32eddb92c7bb6908c0bf6d6 100644 (file)
@@ -225,7 +225,7 @@ static int pch_msi_init(struct device_node *node,
                goto err_priv;
        }
 
-       priv->msi_map = bitmap_alloc(priv->num_irqs, GFP_KERNEL);
+       priv->msi_map = bitmap_zalloc(priv->num_irqs, GFP_KERNEL);
        if (!priv->msi_map) {
                ret = -ENOMEM;
                goto err_priv;