]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net/mlx4_en: Don't configure the HW vxlan parser when vxlan offloading isn't set
authorOr Gerlitz <ogerlitz@mellanox.com>
Wed, 2 Jul 2014 14:36:23 +0000 (17:36 +0300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 8 Jul 2014 04:39:18 +0000 (21:39 -0700)
The add_vxlan_port ndo driver code was wrongly testing whether HW vxlan offloads
are supported by the device instead of checking if they are currently enabled.

This causes the driver to configure the HW parser to conduct matching for vxlan
packets but since no steering rules were set, vxlan packets are dropped on RX.

Fix that by doing the right test, as done in the del_vxlan_port ndo handler.

Fixes: c09aae1 ('net/mlx4: Implement vxlan ndo calls')
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx4/en_netdev.c

index 7d4fb7bf25933ddcddecebf0a551bbe4cfa6328a..e94d96f0ef55fcf0ebe696551d4bf9ab6b040e8a 100644 (file)
@@ -2336,7 +2336,7 @@ static void mlx4_en_add_vxlan_port(struct  net_device *dev,
        struct mlx4_en_priv *priv = netdev_priv(dev);
        __be16 current_port;
 
-       if (!(priv->mdev->dev->caps.flags2 & MLX4_DEV_CAP_FLAG2_VXLAN_OFFLOADS))
+       if (priv->mdev->dev->caps.tunnel_offload_mode != MLX4_TUNNEL_OFFLOAD_MODE_VXLAN)
                return;
 
        if (sa_family == AF_INET6)