]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net: dsa: Add missing of_node_put() in dsa_port_parse_of
authorMiaoqian Lin <linmq006@gmail.com>
Wed, 16 Mar 2022 08:26:02 +0000 (08:26 +0000)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 17 Mar 2022 12:13:27 +0000 (13:13 +0100)
The device_node pointer is returned by of_parse_phandle()  with refcount
incremented. We should use of_node_put() on it when done.

Fixes: 1f0f1d7461e0 ("net: dsa: get port type at parse time")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220316082602.10785-1-linmq006@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/dsa/dsa2.c

index 074e4a69a7284d7aa974470cf229894a48d96524..88e2808019b477c140cdfea62e5bf949e5528c7d 100644 (file)
@@ -1436,6 +1436,7 @@ static int dsa_port_parse_of(struct dsa_port *dp, struct device_node *dn)
                const char *user_protocol;
 
                master = of_find_net_device_by_node(ethernet);
+               of_node_put(ethernet);
                if (!master)
                        return -EPROBE_DEFER;