selftests/powerpc: Return false instead of -1 in require_paranoia_below()

Returning a negative value for a boolean function seem to have the
undesired effect of returning true. require_paranoia_below() is a
boolean function, but the variable used to store the return value is an
integer, receiving -1 or 0. This patch converts rc to bool, replaces -1
by false, and 0 by true.

mpe: This wasn't exhibiting in practice because the common case, where
we do the comparison of the desired level vs the current value, was
being compiled into a computation based on the result of the comparison,
ie. it wasn't using the default -1 value at all. However that was just
luck and the code is still wrong.

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

diff --git a/tools/testing/selftests/powerpc/pmu/lib.c b/tools/testing/selftests/powerpc/pmu/lib.c
index 8b992fa5b478f1d7e2168a9faddaec5cc0247004..5bf5dd40822b10c0accc64669f872f4f8b1c04bf 100644 (file)
--- a/tools/testing/selftests/powerpc/pmu/lib.c
+++ b/tools/testing/selftests/powerpc/pmu/lib.c
@@ -193,9 +193,9 @@ bool require_paranoia_below(int level)
        long current;
        char *end, buf[16];
        FILE *f;
-       int rc;
+       bool rc;
 
-       rc = -1;
+       rc = false;
 
        f = fopen(PARANOID_PATH, "r");
        if (!f) {
@@ -218,7 +218,7 @@ bool require_paranoia_below(int level)
        if (current >= level)
                goto out_close;
 
-       rc = 0;
+       rc = true;
 out_close:
        fclose(f);
 out: