ravb: ravb_close() always returns 0

ravb_close() always returns 0, hence the check in ravb_wol_restore() is
pointless (however, we cannot change the prototype of ravb_close() as it
implements the driver's ndo_stop() method).

Found by Linux Verification Center (linuxtesting.org) with the SVACE static
analysis tool.

Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
index 80366661a361eb38802895d5da145a07524710ac..24e2635c4c8038d1ea9c5be6b8ab7efc6c8b0bf8 100644 (file)
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -2848,7 +2848,6 @@ static int ravb_wol_restore(struct net_device *ndev)
 {
        struct ravb_private *priv = netdev_priv(ndev);
        const struct ravb_hw_info *info = priv->info;
-       int ret;
 
        if (info->nc_queues)
                napi_enable(&priv->napi[RAVB_NC]);
@@ -2857,9 +2856,7 @@ static int ravb_wol_restore(struct net_device *ndev)
        /* Disable MagicPacket */
        ravb_modify(ndev, ECMR, ECMR_MPDE, 0);
 
-       ret = ravb_close(ndev);
-       if (ret < 0)
-               return ret;
+       ravb_close(ndev);
 
        return disable_irq_wake(priv->emac_irq);
 }