]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net/mlx5e: Fix wrong source vport matching on tunnel rule
authorAriel Levkovich <lariel@nvidia.com>
Tue, 15 Mar 2022 16:20:48 +0000 (18:20 +0200)
committerSaeed Mahameed <saeedm@nvidia.com>
Wed, 4 May 2022 07:00:01 +0000 (00:00 -0700)
When OVS internal port is the vtep device, the first decap
rule is matching on the internal port's vport metadata value
and then changes the metadata to be the uplink's value.

Therefore, following rules on the tunnel, in chain > 0, should
avoid matching on internal port metadata and use the uplink
vport metadata instead.

Select the uplink's metadata value for the source vport match
in case the rule is in chain greater than zero, even if the tunnel
route device is internal port.

Fixes: dc7f6661d5d5 ("net/mlx5e: Add indirect tc offload of ovs internal port")
Signed-off-by: Ariel Levkovich <lariel@nvidia.com>
Reviewed-by: Maor Dickman <maord@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c

index 3f63df127091268599c6469a83914ad0ebaec68f..3b151332e2f8944b026fa99602d3c87ccf832958 100644 (file)
@@ -139,7 +139,7 @@ mlx5_eswitch_set_rule_source_port(struct mlx5_eswitch *esw,
                if (mlx5_esw_indir_table_decap_vport(attr))
                        vport = mlx5_esw_indir_table_decap_vport(attr);
 
-               if (esw_attr->int_port)
+               if (attr && !attr->chain && esw_attr->int_port)
                        metadata =
                                mlx5e_tc_int_port_get_metadata_for_match(esw_attr->int_port);
                else