ASoC: amd: acp: Fix return value check in acp_machine_select()

In case of error, platform_device_register_data() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check
should be replaced with IS_ERR().

Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: b7acde003667 ("ASoC: amd: acp: Add callback for machine driver on ACP")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20211027065228.833825-1-yangyingliang@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/amd/acp/acp-platform.c b/sound/soc/amd/acp/acp-platform.c
index 75003d0a41e36685d2683a65cff8d6a2395fdc4f..65a809e2c29fffc31533df6f56a27883ea3b6795 100644 (file)
--- a/sound/soc/amd/acp/acp-platform.c
+++ b/sound/soc/amd/acp/acp-platform.c
@@ -81,7 +81,7 @@ int acp_machine_select(struct acp_dev_data *adata)
 
        adata->mach_dev = platform_device_register_data(adata->dev, mach->drv_name,
                                                        PLATFORM_DEVID_NONE, mach, size);
-       if (!adata->mach_dev)
+       if (IS_ERR(adata->mach_dev))
                dev_warn(adata->dev, "Unable to register Machine device\n");
 
        return 0;