crypto: sun8i-ss - fix error codes in allocate_flows()

These failure paths should return -ENOMEM.  Currently they return
success.

Fixes: ac5d04edd6f3 ("crypto: sun8i-ss - rework handling of IV")
Fixes: 8fcfe2ced02c ("crypto: sun8i-ss - do not allocate memory when handling hash requests")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Tested-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
index 98593a0cff6943a2fdf8fd0433422301f54b1b32..ac2329e2b0e58e95d0bccd914a17272bb22db195 100644 (file)
--- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
+++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
@@ -528,25 +528,33 @@ static int allocate_flows(struct sun8i_ss_dev *ss)
 
                ss->flows[i].biv = devm_kmalloc(ss->dev, AES_BLOCK_SIZE,
                                                GFP_KERNEL | GFP_DMA);
-               if (!ss->flows[i].biv)
+               if (!ss->flows[i].biv) {
+                       err = -ENOMEM;
                        goto error_engine;
+               }
 
                for (j = 0; j < MAX_SG; j++) {
                        ss->flows[i].iv[j] = devm_kmalloc(ss->dev, AES_BLOCK_SIZE,
                                                          GFP_KERNEL | GFP_DMA);
-                       if (!ss->flows[i].iv[j])
+                       if (!ss->flows[i].iv[j]) {
+                               err = -ENOMEM;
                                goto error_engine;
+                       }
                }
 
                /* the padding could be up to two block. */
                ss->flows[i].pad = devm_kmalloc(ss->dev, MAX_PAD_SIZE,
                                                GFP_KERNEL | GFP_DMA);
-               if (!ss->flows[i].pad)
+               if (!ss->flows[i].pad) {
+                       err = -ENOMEM;
                        goto error_engine;
+               }
                ss->flows[i].result = devm_kmalloc(ss->dev, SHA256_DIGEST_SIZE,
                                                   GFP_KERNEL | GFP_DMA);
-               if (!ss->flows[i].result)
+               if (!ss->flows[i].result) {
+                       err = -ENOMEM;
                        goto error_engine;
+               }
 
                ss->flows[i].engine = crypto_engine_alloc_init(ss->dev, true);
                if (!ss->flows[i].engine) {