]> git.baikalelectronics.ru Git - kernel.git/commitdiff
drm/vc4: remove check of return value of drm_debugfs functions
authorWambui Karuga <wambui.karugax@gmail.com>
Tue, 10 Mar 2020 13:31:08 +0000 (16:31 +0300)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 18 Mar 2020 15:22:20 +0000 (16:22 +0100)
Since 987d65d01356 (drm: debugfs: make
drm_debugfs_create_files() never fail), drm_debugfs_create_files() never
fails and should return void. Therefore, remove unnecessary check and
error handling for the return value of drm_debugfs_create_files()
in vc4_debugfs_init().

v2: remove conversion of vc4_debugfs_init() to void to enable individual
compilation and avoid build issues and breakage.

References: https://lists.freedesktop.org/archives/dri-devel/2020-February/257183.html
Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20200310133121.27913-5-wambui.karugax@gmail.com
drivers/gpu/drm/vc4/vc4_debugfs.c

index b61b2d3407b516c2c819584652a9051ffa5cb53c..1835f12337ece87c50e1e1976eb9dab0637b09f0 100644 (file)
@@ -30,11 +30,8 @@ vc4_debugfs_init(struct drm_minor *minor)
                            minor->debugfs_root, &vc4->load_tracker_enabled);
 
        list_for_each_entry(entry, &vc4->debugfs_list, link) {
-               int ret = drm_debugfs_create_files(&entry->info, 1,
-                                                  minor->debugfs_root, minor);
-
-               if (ret)
-                       return ret;
+               drm_debugfs_create_files(&entry->info, 1,
+                                        minor->debugfs_root, minor);
        }
 
        return 0;