]> git.baikalelectronics.ru Git - kernel.git/commitdiff
mm: fix VM_BUG_ON in __delete_from_swap_cache()
authorMatthew Wilcox (Oracle) <willy@infradead.org>
Fri, 2 Sep 2022 19:26:38 +0000 (20:26 +0100)
committerAndrew Morton <akpm@linux-foundation.org>
Sun, 11 Sep 2022 23:22:31 +0000 (16:22 -0700)
Patch series "Folio fixes for 6.0".

This patch (of 2):

The recent folio conversion changed the VM_BUG_ON() to dump the folio
we're storing instead of the entry we retrieved.  This was a mistake;
the entry we retrieved is the more interesting page to dump.

Link: https://lkml.kernel.org/r/20220902192639.1737108-1-willy@infradead.org
Link: https://lkml.kernel.org/r/20220902192639.1737108-2-willy@infradead.org
Fixes: 318959ba7cbe ("mm/swap: convert __delete_from_swap_cache() to a folio")
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Cc: Hugh Dickins <hughd@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/swap_state.c

index e166051566f42425c3eacccb1451bc47c88bd37b..41afa6d45b2394d9eb74953b619906e62ce448b2 100644 (file)
@@ -151,7 +151,7 @@ void __delete_from_swap_cache(struct folio *folio,
 
        for (i = 0; i < nr; i++) {
                void *entry = xas_store(&xas, shadow);
-               VM_BUG_ON_FOLIO(entry != folio, folio);
+               VM_BUG_ON_PAGE(entry != folio, entry);
                set_page_private(folio_page(folio, i), 0);
                xas_next(&xas);
        }