]> git.baikalelectronics.ru Git - kernel.git/commitdiff
csky: Fixup regs.sr broken in ptrace
authorGuo Ren <guoren@linux.alibaba.com>
Fri, 24 Sep 2021 07:33:38 +0000 (15:33 +0800)
committerGuo Ren <guoren@linux.alibaba.com>
Fri, 15 Oct 2021 23:20:12 +0000 (07:20 +0800)
gpr_get() return the entire pt_regs (include sr) to userspace, if we
don't restore the C bit in gpr_set, it may break the ALU result in
that context. So the C flag bit is part of gpr context, that's why
riscv totally remove the C bit in the ISA. That makes sr reg clear
from userspace to supervisor privilege.

Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: stable@vger.kernel.org
arch/csky/kernel/ptrace.c

index 0105ac81b4328adc090342543cd4601c048aed7d..1a5f54e0d272631137179c848715a7ab8a5791ff 100644 (file)
@@ -99,7 +99,8 @@ static int gpr_set(struct task_struct *target,
        if (ret)
                return ret;
 
-       regs.sr = task_pt_regs(target)->sr;
+       /* BIT(0) of regs.sr is Condition Code/Carry bit */
+       regs.sr = (regs.sr & BIT(0)) | (task_pt_regs(target)->sr & ~BIT(0));
 #ifdef CONFIG_CPU_HAS_HILO
        regs.dcsr = task_pt_regs(target)->dcsr;
 #endif