]> git.baikalelectronics.ru Git - kernel.git/commitdiff
ASoC: soc-pcm: fix the return value in dpcm_apply_symmetry()
authorJaroslav Kysela <perex@perex.cz>
Mon, 14 Jun 2021 07:17:46 +0000 (09:17 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 14 Jun 2021 13:59:17 +0000 (14:59 +0100)
In case, where the loops are not executed for a reason, the uninitialized
variable 'err' is returned to the caller. Make code fully predictible
and assign zero in the declaration.

Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Cc: Mark Brown <broonie@kernel.org>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/20210614071746.1787072-1-perex@perex.cz
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-pcm.c

index 8659089a87a09c3848fb5a25b213a72f380ea798..46513bb97904473cf6f4baeddc04a1c9c802f0f9 100644 (file)
@@ -1700,7 +1700,7 @@ static int dpcm_apply_symmetry(struct snd_pcm_substream *fe_substream,
        struct snd_soc_dpcm *dpcm;
        struct snd_soc_pcm_runtime *fe = asoc_substream_to_rtd(fe_substream);
        struct snd_soc_dai *fe_cpu_dai;
-       int err;
+       int err = 0;
        int i;
 
        /* apply symmetry for FE */