drm/nouveau/pmu: don't print reply values if exec is false

Currently the uninitialized values in the array reply are printed out
when exec is false and nvkm_pmu_send has not updated the array. Avoid
confusion by only dumping out these values if they have been actually
updated.

Detected by CoverityScan, CID#1271291 ("Uninitialized scaler variable")
Fixes: 6aad52bc87aa ("drm/nouveau/pmu: rename from pwr (no binary change)")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>

diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/memx.c b/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/memx.c
index 11b28b086a062f7ba2cea541fb391095ea2cec43..7b052879af7287a33c7ce0585f9c46e5f9d99403 100644 (file)
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/memx.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/memx.c
@@ -88,10 +88,10 @@ nvkm_memx_fini(struct nvkm_memx **pmemx, bool exec)
        if (exec) {
                nvkm_pmu_send(pmu, reply, PROC_MEMX, MEMX_MSG_EXEC,
                              memx->base, finish);
+               nvkm_debug(subdev, "Exec took %uns, PMU_IN %08x\n",
+                          reply[0], reply[1]);
        }
 
-       nvkm_debug(subdev, "Exec took %uns, PMU_IN %08x\n",
-                  reply[0], reply[1]);
        kfree(memx);
        return 0;
 }