]> git.baikalelectronics.ru Git - kernel.git/commitdiff
arm64/sme: Fix NULL check after kzalloc
authorWan Jiabing <wanjiabing@vivo.com>
Tue, 26 Apr 2022 11:30:53 +0000 (19:30 +0800)
committerCatalin Marinas <catalin.marinas@arm.com>
Fri, 29 Apr 2022 15:03:47 +0000 (16:03 +0100)
Fix following coccicheck error:
./arch/arm64/kernel/process.c:322:2-23: alloc with no test, possible model on line 326

Here should be dst->thread.sve_state.

Fixes: 34097d351fdb ("arm64/sme: Implement traps and syscall handling for SME")
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Reviwed-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20220426113054.630983-1-wanjiabing@vivo.com
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
arch/arm64/kernel/process.c

index 99c293513817844e7631924b32b603333bef0dcb..9734c9fb1a32c0e12b3f8be22dff8e7885838deb 100644 (file)
@@ -321,7 +321,7 @@ int arch_dup_task_struct(struct task_struct *dst, struct task_struct *src)
        if (thread_za_enabled(&src->thread)) {
                dst->thread.sve_state = kzalloc(sve_state_size(src),
                                                GFP_KERNEL);
-               if (!dst->thread.za_state)
+               if (!dst->thread.sve_state)
                        return -ENOMEM;
                dst->thread.za_state = kmemdup(src->thread.za_state,
                                               za_state_size(src),