regulator: fix null pointer check on regmap

The null pointer check on regmap that checks for a dev_get_regmap failure
is currently returning -ENOENT if the regmap succeeded. Fix this by adding
in the missing ! operator.

Fixes: 4860158b45b4 ("regulator: Add support for QCOM PMIC VBUS booster")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Addresses-Coverity: ("Dereference after null check")
Link: https://lore.kernel.org/r/20200702115659.38208-1-colin.king@canonical.com
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/drivers/regulator/qcom_usb_vbus-regulator.c b/drivers/regulator/qcom_usb_vbus-regulator.c
index 342d923735982fc7fbb35c4c47b5b60ee80b03ae..8ba947f3585f53bfe72b9f3e6cbc78d8fd0942fc 100644 (file)
--- a/drivers/regulator/qcom_usb_vbus-regulator.c
+++ b/drivers/regulator/qcom_usb_vbus-regulator.c
@@ -49,7 +49,7 @@ static int qcom_usb_vbus_regulator_probe(struct platform_device *pdev)
        }
 
        regmap = dev_get_regmap(dev->parent, NULL);
-       if (regmap) {
+       if (!regmap) {
                dev_err(dev, "Failed to get regmap\n");
                return -ENOENT;
        }