]> git.baikalelectronics.ru Git - kernel.git/commitdiff
block: Fix the enum blk_eh_timer_return documentation
authorBart Van Assche <bvanassche@acm.org>
Tue, 20 Sep 2022 20:06:26 +0000 (13:06 -0700)
committerJens Axboe <axboe@kernel.dk>
Wed, 21 Sep 2022 14:34:37 +0000 (08:34 -0600)
The documentation of the blk_eh_timer_return enumeration values does not
reflect correctly how e.g. the SCSI core uses these values. Fix the
documentation.

Cc: Christoph Hellwig <hch@lst.de>
Cc: Ming Lei <ming.lei@redhat.com>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Damien Le Moal <damien.lemoal@wdc.com>
Cc: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Fixes: 88b0cfad2888 ("block: document the blk_eh_timer_return values")
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Link: https://lore.kernel.org/r/20220920200626.3422296-1-bvanassche@acm.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
include/linux/blk-mq.h

index 74b99d716b0b3fc984dd31707b6d65621014c7a9..e21ff85751cf775993374c77fd6c02cd1b6d398e 100644 (file)
@@ -268,9 +268,16 @@ static inline void rq_list_move(struct request **src, struct request **dst,
        rq_list_add(dst, rq);
 }
 
+/**
+ * enum blk_eh_timer_return - How the timeout handler should proceed
+ * @BLK_EH_DONE: The block driver completed the command or will complete it at
+ *     a later time.
+ * @BLK_EH_RESET_TIMER: Reset the request timer and continue waiting for the
+ *     request to complete.
+ */
 enum blk_eh_timer_return {
-       BLK_EH_DONE,            /* drivers has completed the command */
-       BLK_EH_RESET_TIMER,     /* reset timer and try again */
+       BLK_EH_DONE,
+       BLK_EH_RESET_TIMER,
 };
 
 #define BLK_TAG_ALLOC_FIFO 0 /* allocate starting from 0 */