crypto: testmgr - remove bfin_crc "hmac(crc32)" test vectors

The Blackfin CRC driver was removed by commit 28ebd996ed70 ("crypto:
bfin_crc - remove blackfin CRC driver"), but it was forgotten to remove
the corresponding "hmac(crc32)" test vectors.  I see no point in keeping
them since nothing else appears to implement or use "hmac(crc32)", which
isn't an algorithm that makes sense anyway because HMAC is meant to be
used with a cryptographically secure hash function, which CRC's are not.

Thus, remove the unneeded test vectors.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c
index e721faab6fc8a44d158eb4ef70bda130d2d14c2a..d5bcdd905007a217767ca86b228fa57eaeea0b12 100644 (file)
--- a/crypto/tcrypt.c
+++ b/crypto/tcrypt.c
@@ -1942,10 +1942,6 @@ static int do_test(const char *alg, u32 type, u32 mask, int m, u32 num_mb)
                ret += tcrypt_test("vmac(aes)");
                break;
 
-       case 110:
-               ret += tcrypt_test("hmac(crc32)");
-               break;
-
        case 111:
                ret += tcrypt_test("hmac(sha3-224)");
                break;

diff --git a/crypto/testmgr.c b/crypto/testmgr.c
index 41a5f42d4104e4f6b920b3f300fad0ec3ca7bb42..7e57530ecd521b6011bde27d23d429b33f580a2c 100644 (file)
--- a/crypto/testmgr.c
+++ b/crypto/testmgr.c
@@ -3168,12 +3168,6 @@ static const struct alg_test_desc alg_test_descs[] = {
                .suite = {
                        .hash = __VECS(ghash_tv_template)
                }
-       }, {
-               .alg = "hmac(crc32)",
-               .test = alg_test_hash,
-               .suite = {
-                       .hash = __VECS(bfin_crc_tv_template)
-               }
        }, {
                .alg = "hmac(md5)",
                .test = alg_test_hash,

diff --git a/crypto/testmgr.h b/crypto/testmgr.h
index 552d8f00d85b2a1abc719e7096ea15dcb1c678e4..816e3eb197b2c5ab12c9897117bd3b890f73ef5c 100644 (file)
--- a/crypto/testmgr.h
+++ b/crypto/testmgr.h
@@ -43156,94 +43156,6 @@ static const struct hash_testvec crc32c_tv_template[] = {
        }
 };
 
-/*
- * Blakcifn CRC test vectors
- */
-static const struct hash_testvec bfin_crc_tv_template[] = {
-       {
-               .psize = 0,
-               .digest = "\x00\x00\x00\x00",
-       },
-       {
-               .key = "\x87\xa9\xcb\xed",
-               .ksize = 4,
-               .psize = 0,
-               .digest = "\x87\xa9\xcb\xed",
-       },
-       {
-               .key = "\xff\xff\xff\xff",
-               .ksize = 4,
-               .plaintext = "\x01\x02\x03\x04\x05\x06\x07\x08"
-                            "\x09\x0a\x0b\x0c\x0d\x0e\x0f\x10"
-                            "\x11\x12\x13\x14\x15\x16\x17\x18"
-                            "\x19\x1a\x1b\x1c\x1d\x1e\x1f\x20"
-                            "\x21\x22\x23\x24\x25\x26\x27\x28",
-               .psize = 40,
-               .digest = "\x84\x0c\x8d\xa2",
-       },
-       {
-               .key = "\xff\xff\xff\xff",
-               .ksize = 4,
-               .plaintext = "\x01\x02\x03\x04\x05\x06\x07\x08"
-                            "\x09\x0a\x0b\x0c\x0d\x0e\x0f\x10"
-                            "\x11\x12\x13\x14\x15\x16\x17\x18"
-                            "\x19\x1a\x1b\x1c\x1d\x1e\x1f\x20"
-                            "\x21\x22\x23\x24\x25\x26",
-               .psize = 38,
-               .digest = "\x8c\x58\xec\xb7",
-       },
-       {
-               .key = "\xff\xff\xff\xff",
-               .ksize = 4,
-               .plaintext = "\x01\x02\x03\x04\x05\x06\x07\x08"
-                            "\x09\x0a\x0b\x0c\x0d\x0e\x0f\x10"
-                            "\x11\x12\x13\x14\x15\x16\x17\x18"
-                            "\x19\x1a\x1b\x1c\x1d\x1e\x1f\x20"
-                            "\x21\x22\x23\x24\x25\x26\x27",
-               .psize = 39,
-               .digest = "\xdc\x50\x28\x7b",
-       },
-       {
-               .key = "\xff\xff\xff\xff",
-               .ksize = 4,
-               .plaintext = "\x01\x02\x03\x04\x05\x06\x07\x08"
-                            "\x09\x0a\x0b\x0c\x0d\x0e\x0f\x10"
-                            "\x11\x12\x13\x14\x15\x16\x17\x18"
-                            "\x19\x1a\x1b\x1c\x1d\x1e\x1f\x20"
-                            "\x21\x22\x23\x24\x25\x26\x27\x28"
-                            "\x29\x2a\x2b\x2c\x2d\x2e\x2f\x30"
-                            "\x31\x32\x33\x34\x35\x36\x37\x38"
-                            "\x39\x3a\x3b\x3c\x3d\x3e\x3f\x40"
-                            "\x41\x42\x43\x44\x45\x46\x47\x48"
-                            "\x49\x4a\x4b\x4c\x4d\x4e\x4f\x50"
-                            "\x51\x52\x53\x54\x55\x56\x57\x58"
-                            "\x59\x5a\x5b\x5c\x5d\x5e\x5f\x60"
-                            "\x61\x62\x63\x64\x65\x66\x67\x68"
-                            "\x69\x6a\x6b\x6c\x6d\x6e\x6f\x70"
-                            "\x71\x72\x73\x74\x75\x76\x77\x78"
-                            "\x79\x7a\x7b\x7c\x7d\x7e\x7f\x80"
-                            "\x81\x82\x83\x84\x85\x86\x87\x88"
-                            "\x89\x8a\x8b\x8c\x8d\x8e\x8f\x90"
-                            "\x91\x92\x93\x94\x95\x96\x97\x98"
-                            "\x99\x9a\x9b\x9c\x9d\x9e\x9f\xa0"
-                            "\xa1\xa2\xa3\xa4\xa5\xa6\xa7\xa8"
-                            "\xa9\xaa\xab\xac\xad\xae\xaf\xb0"
-                            "\xb1\xb2\xb3\xb4\xb5\xb6\xb7\xb8"
-                            "\xb9\xba\xbb\xbc\xbd\xbe\xbf\xc0"
-                            "\xc1\xc2\xc3\xc4\xc5\xc6\xc7\xc8"
-                            "\xc9\xca\xcb\xcc\xcd\xce\xcf\xd0"
-                            "\xd1\xd2\xd3\xd4\xd5\xd6\xd7\xd8"
-                            "\xd9\xda\xdb\xdc\xdd\xde\xdf\xe0"
-                            "\xe1\xe2\xe3\xe4\xe5\xe6\xe7\xe8"
-                            "\xe9\xea\xeb\xec\xed\xee\xef\xf0",
-               .psize = 240,
-               .digest = "\x10\x19\x4a\x5c",
-               .np = 2,
-               .tap = { 31, 209 }
-       },
-
-};
-
 static const struct comp_testvec lz4_comp_tv_template[] = {
        {
                .inlen  = 255,