]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net: dsa: don't fail to probe if we couldn't set the MTU
authorVladimir Oltean <vladimir.oltean@nxp.com>
Tue, 21 Apr 2020 17:18:53 +0000 (20:18 +0300)
committerDavid S. Miller <davem@davemloft.net>
Thu, 23 Apr 2020 02:22:59 +0000 (19:22 -0700)
There is no reason to fail the probing of the switch if the MTU couldn't
be configured correctly (either the switch port itself, or the host
port) for whatever reason. MTU-sized traffic probably won't work, sure,
but we can still probably limp on and support some form of communication
anyway, which the users would probably appreciate more.

Fixes: b202c04f8d0d ("net: dsa: configure the MTU for switch ports")
Reported-by: Oleksij Rempel <o.rempel@pengutronix.de>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/dsa/slave.c

index e94eb1aac6029e41b65bd2c1ceb044992aec3a4a..d1068803cd1116781e53052a6defe8b9ae9b9fe1 100644 (file)
@@ -1770,11 +1770,9 @@ int dsa_slave_create(struct dsa_port *port)
        rtnl_lock();
        ret = dsa_slave_change_mtu(slave_dev, ETH_DATA_LEN);
        rtnl_unlock();
-       if (ret && ret != -EOPNOTSUPP) {
-               dev_err(ds->dev, "error %d setting MTU on port %d\n",
-                       ret, port->index);
-               goto out_free;
-       }
+       if (ret)
+               dev_warn(ds->dev, "nonfatal error %d setting MTU on port %d\n",
+                        ret, port->index);
 
        netif_carrier_off(slave_dev);