]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net: devlink: remove redundant net_eq() check from sb_pool_get_dumpit()
authorJiri Pirko <jiri@nvidia.com>
Wed, 27 Jul 2022 05:59:12 +0000 (07:59 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 28 Jul 2022 01:54:25 +0000 (18:54 -0700)
The net_eq() check is already performed inside
devlinks_xa_for_each_registered_get() helper, so remove the redundant
appearance.

Signed-off-by: Jiri Pirko <jiri@nvidia.com>
Link: https://lore.kernel.org/r/20220727055912.568391-1-jiri@resnulli.us
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/devlink.c

index 698b2d6e0ec7d1d7e8138da694e0a5cbdc8b86b1..ca4c9939d56963d64a7d997dfc33858e8d4bb856 100644 (file)
@@ -2642,8 +2642,7 @@ static int devlink_nl_cmd_sb_pool_get_dumpit(struct sk_buff *msg,
 
        mutex_lock(&devlink_mutex);
        devlinks_xa_for_each_registered_get(sock_net(msg->sk), index, devlink) {
-               if (!net_eq(devlink_net(devlink), sock_net(msg->sk)) ||
-                   !devlink->ops->sb_pool_get)
+               if (!devlink->ops->sb_pool_get)
                        goto retry;
 
                devl_lock(devlink);