]> git.baikalelectronics.ru Git - kernel.git/commitdiff
octeontx2-pf: Fix uninitialized boolean variable pps
authorColin Ian King <colin.king@canonical.com>
Mon, 12 Jul 2021 14:37:50 +0000 (15:37 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 12 Jul 2021 18:26:28 +0000 (11:26 -0700)
In the case where act->id is FLOW_ACTION_POLICE and also
act->police.rate_bytes_ps > 0 or act->police.rate_pkt_ps is not > 0
the boolean variable pps contains an uninitialized value when
function otx2_tc_act_set_police is called. Fix this by initializing
pps to false.

Addresses-Coverity: ("Uninitialized scalar variable)"
Fixes: 8c9d835588f1 ("octeontx2-pf: Add police action for TC flower")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c

index 905fc02a7dfed78012adc47af0c3b96cc8e33a2c..972b202b9884d82cc59a1f819add32d48a44b34b 100644 (file)
@@ -288,7 +288,7 @@ static int otx2_tc_parse_actions(struct otx2_nic *nic,
        struct otx2_nic *priv;
        u32 burst, mark = 0;
        u8 nr_police = 0;
-       bool pps;
+       bool pps = false;
        u64 rate;
        int i;