]> git.baikalelectronics.ru Git - kernel.git/commitdiff
selftests/bpf: Cleanup some file descriptors in test_maps
authorAnton Protopopov <a.s.protopopov@gmail.com>
Wed, 27 May 2020 18:56:57 +0000 (18:56 +0000)
committerAlexei Starovoitov <ast@kernel.org>
Mon, 1 Jun 2020 21:38:21 +0000 (14:38 -0700)
The test_map_rdonly and test_map_wronly tests should close file descriptors
which they open.

Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/20200527185700.14658-3-a.s.protopopov@gmail.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
tools/testing/selftests/bpf/test_maps.c

index f717acc0c68d862eb681f75924d46dd1fbcdf122..46cf2c232964a0907321983368c0c24ebaca4bd7 100644 (file)
@@ -1401,6 +1401,8 @@ static void test_map_rdonly(void)
        /* Check that key=2 is not found. */
        assert(bpf_map_lookup_elem(fd, &key, &value) == -1 && errno == ENOENT);
        assert(bpf_map_get_next_key(fd, &key, &value) == -1 && errno == ENOENT);
+
+       close(fd);
 }
 
 static void test_map_wronly(void)
@@ -1423,6 +1425,8 @@ static void test_map_wronly(void)
        /* Check that key=2 is not found. */
        assert(bpf_map_lookup_elem(fd, &key, &value) == -1 && errno == EPERM);
        assert(bpf_map_get_next_key(fd, &key, &value) == -1 && errno == EPERM);
+
+       close(fd);
 }
 
 static void prepare_reuseport_grp(int type, int map_fd, size_t map_elem_size,