]> git.baikalelectronics.ru Git - kernel.git/commitdiff
drm/i915/selftest: Fix use of err in igt_reset_{fail, nop}_engine()
authorNathan Chancellor <nathan@kernel.org>
Fri, 13 Aug 2021 17:11:58 +0000 (10:11 -0700)
committerJoonas Lahtinen <joonas.lahtinen@linux.intel.com>
Tue, 24 Aug 2021 09:21:50 +0000 (12:21 +0300)
Clang warns:

In file included from drivers/gpu/drm/i915/gt/intel_reset.c:1514:
drivers/gpu/drm/i915/gt/selftest_hangcheck.c:465:62: warning: variable
'err' is uninitialized when used here [-Wuninitialized]
        pr_err("[%s] Create context failed: %d!\n", engine->name, err);
                                                                  ^~~
...
drivers/gpu/drm/i915/gt/selftest_hangcheck.c:580:62: warning: variable
'err' is uninitialized when used here [-Wuninitialized]
        pr_err("[%s] Create context failed: %d!\n", engine->name, err);
                                                                  ^~~
...
2 warnings generated.

This appears to be a copy and paste issue. Use ce directly using the %pe
specifier to pretty print the error code so that err is not used
uninitialized in these functions.

Fixes: 3a7b72665ea5 ("drm/i915/selftest: Bump selftest timeouts for hangcheck")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210813171158.2665823-1-nathan@kernel.org
drivers/gpu/drm/i915/gt/selftest_hangcheck.c

index 08f011f893b27437c58ec515eca447267661f06b..2c1ed32ca5acde9a40307f5ed6dd43d1b86bd2fe 100644 (file)
@@ -462,7 +462,7 @@ static int igt_reset_nop_engine(void *arg)
 
                ce = intel_context_create(engine);
                if (IS_ERR(ce)) {
-                       pr_err("[%s] Create context failed: %d!\n", engine->name, err);
+                       pr_err("[%s] Create context failed: %pe!\n", engine->name, ce);
                        return PTR_ERR(ce);
                }
 
@@ -577,7 +577,7 @@ static int igt_reset_fail_engine(void *arg)
 
                ce = intel_context_create(engine);
                if (IS_ERR(ce)) {
-                       pr_err("[%s] Create context failed: %d!\n", engine->name, err);
+                       pr_err("[%s] Create context failed: %pe!\n", engine->name, ce);
                        return PTR_ERR(ce);
                }