powerpc/xive: Remove irqd_is_started() check when setting the affinity

In the early days of XIVE support, commit b8c61a0f1980 ("powerpc/xive:
Ensure active irqd when setting affinity") tried to fix an issue
related to interrupt migration. If the root cause was related to CPU
unplug, it should have been fixed and there is no reason to keep the
irqd_is_started() check. This test is also breaking affinity setting
of MSIs which can set before starting the associated IRQ.

Signed-off-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20210701132750.1475580-8-clg@kaod.org

diff --git a/arch/powerpc/sysdev/xive/common.c b/arch/powerpc/sysdev/xive/common.c
index 356f584cc51ba459e489cff9e548857d60d6c61e..0631c97b3a144cd2da9f955449753a1810c057ba 100644 (file)
--- a/arch/powerpc/sysdev/xive/common.c
+++ b/arch/powerpc/sysdev/xive/common.c
@@ -709,10 +709,6 @@ static int xive_irq_set_affinity(struct irq_data *d,
        if (cpumask_any_and(cpumask, cpu_online_mask) >= nr_cpu_ids)
                return -EINVAL;
 
-       /* Don't do anything if the interrupt isn't started */
-       if (!irqd_is_started(d))
-               return IRQ_SET_MASK_OK;
-
        /*
         * If existing target is already in the new mask, and is
         * online then do nothing.