pinctrl: intel: unlock on error in intel_config_set_pull()

We need to unlock before returning -EINVAL on this error path.

Fixes: 04cc058f0c52 ("pinctrl: intel: Add support for 1k additional pull-down")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c
index 523264463d35cfba7a0fa4ba01d78a9bcee09b73..592b465e981ef85ecd55c0ce1112f55831aa7f4c 100644 (file)
--- a/drivers/pinctrl/intel/pinctrl-intel.c
+++ b/drivers/pinctrl/intel/pinctrl-intel.c
@@ -599,8 +599,10 @@ static int intel_config_set_pull(struct intel_pinctrl *pctrl, unsigned pin,
                        value |= PADCFG1_TERM_5K << PADCFG1_TERM_SHIFT;
                        break;
                case 1000:
-                       if (!(community->features & PINCTRL_FEATURE_1K_PD))
-                               return -EINVAL;
+                       if (!(community->features & PINCTRL_FEATURE_1K_PD)) {
+                               ret = -EINVAL;
+                               break;
+                       }
                        value |= PADCFG1_TERM_1K << PADCFG1_TERM_SHIFT;
                        break;
                default: