]> git.baikalelectronics.ru Git - kernel.git/commitdiff
drm/mcde: Fix refcount leak in mcde_dsi_bind
authorMiaoqian Lin <linmq006@gmail.com>
Wed, 25 May 2022 11:54:11 +0000 (15:54 +0400)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 27 Jun 2022 07:58:41 +0000 (09:58 +0200)
Every iteration of for_each_available_child_of_node() decrements
the reference counter of the previous node. There is no decrement
when break out from the loop and results in refcount leak.
Add missing of_node_put() to fix this.

Fixes: b54b2b95e2dd ("drm/mcde: Add new driver for ST-Ericsson MCDE")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220525115411.65455-1-linmq006@gmail.com
drivers/gpu/drm/mcde/mcde_dsi.c

index 5651734ce977f287c431604c69447c2f1fd2cacb..9f9ac8699310d693af3129cf6f71210ceb98c96c 100644 (file)
@@ -1111,6 +1111,7 @@ static int mcde_dsi_bind(struct device *dev, struct device *master,
                        bridge = of_drm_find_bridge(child);
                        if (!bridge) {
                                dev_err(dev, "failed to find bridge\n");
+                               of_node_put(child);
                                return -EINVAL;
                        }
                }