]> git.baikalelectronics.ru Git - kernel.git/commitdiff
drm/ast: remove duplicate assignment of ast_crtc_funcs member
authorJason Yan <yanaijie@huawei.com>
Wed, 29 Apr 2020 14:10:10 +0000 (22:10 +0800)
committerThomas Zimmermann <tzimmermann@suse.de>
Thu, 30 Apr 2020 08:41:05 +0000 (10:41 +0200)
The struct member 'set_config' was assigned twice:

static const struct drm_crtc_funcs ast_crtc_funcs = {
.reset = ast_crtc_reset,
.set_config = drm_crtc_helper_set_config,
......
.set_config = drm_atomic_helper_set_config,
......
};

Since the second one is which we use now in fact, we can remove the
first one.

This fixes the following coccicheck warning:

drivers/gpu/drm/ast/ast_mode.c:932:50-51: set_config: first occurrence
line 934, second occurrence line 937

Signed-off-by: Jason Yan <yanaijie@huawei.com>
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20200429141010.8445-1-yanaijie@huawei.com
drivers/gpu/drm/ast/ast_mode.c

index d2ab81f9c4987db44c7e1d35a26e7302fa989671..7062bcd78740bbd462e69f6573658cf49d2460a0 100644 (file)
@@ -931,7 +931,6 @@ static void ast_crtc_atomic_destroy_state(struct drm_crtc *crtc,
 
 static const struct drm_crtc_funcs ast_crtc_funcs = {
        .reset = ast_crtc_reset,
-       .set_config = drm_crtc_helper_set_config,
        .gamma_set = drm_atomic_helper_legacy_gamma_set,
        .destroy = ast_crtc_destroy,
        .set_config = drm_atomic_helper_set_config,