]> git.baikalelectronics.ru Git - kernel.git/commitdiff
ACPI: processor: Check for null return of devm_kzalloc() in fch_misc_setup()
authorKang Chen <void0red@gmail.com>
Sun, 26 Feb 2023 05:54:27 +0000 (13:54 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 24 May 2023 16:32:35 +0000 (17:32 +0100)
[ Upstream commit 4dea41775d951ff1f7b472a346a8ca3ae7e74455 ]

devm_kzalloc() may fail, clk_data->name might be NULL and will
cause a NULL pointer dereference later.

Signed-off-by: Kang Chen <void0red@gmail.com>
[ rjw: Subject and changelog edits ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/acpi/acpi_apd.c

index 3bbe2276cac7674fbacb83205c6d714f96863243..80f945cbec8a7cf12502400575a02a455594ed10 100644 (file)
@@ -83,6 +83,8 @@ static int fch_misc_setup(struct apd_private_data *pdata)
        if (!acpi_dev_get_property(adev, "clk-name", ACPI_TYPE_STRING, &obj)) {
                clk_data->name = devm_kzalloc(&adev->dev, obj->string.length,
                                              GFP_KERNEL);
+               if (!clk_data->name)
+                       return -ENOMEM;
 
                strcpy(clk_data->name, obj->string.pointer);
        } else {