virt/coco/sev-guest: Simplify extended guest request handling

commit 5f3b250743c5bbf088f738f7794f3eec22746811 upstream.

Return a specific error code - -ENOSPC - to signal the too small cert
data buffer instead of checking exit code and exitinfo2.

While at it, hoist the *fw_err assignment in snp_issue_guest_request()
so that a proper error value is returned to the callers.

  [ Tom: check override_err instead of err. ]

Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Link: https://lore.kernel.org/r/20230307192449.24732-4-bp@alien8.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/arch/x86/kernel/sev.c b/arch/x86/kernel/sev.c
index 2e739b0b75331fe9d5619bb6a6acc7360d0fc6a7..5dc9c53a5d6fb0701658bf216b3d2d65dcf3cf10 100644 (file)
--- a/arch/x86/kernel/sev.c
+++ b/arch/x86/kernel/sev.c
@@ -2209,15 +2209,16 @@ int snp_issue_guest_request(u64 exit_code, struct snp_req_data *input, unsigned
        if (ret)
                goto e_put;
 
+       *fw_err = ghcb->save.sw_exit_info_2;
        if (ghcb->save.sw_exit_info_2) {
                /* Number of expected pages are returned in RBX */
                if (exit_code == SVM_VMGEXIT_EXT_GUEST_REQUEST &&
-                   ghcb->save.sw_exit_info_2 == SNP_GUEST_REQ_INVALID_LEN)
+                   ghcb->save.sw_exit_info_2 == SNP_GUEST_REQ_INVALID_LEN) {
                        input->data_npages = ghcb_get_rbx(ghcb);
-
-               *fw_err = ghcb->save.sw_exit_info_2;
-
-               ret = -EIO;
+                       ret = -ENOSPC;
+               } else {
+                       ret = -EIO;
+               }
        }
 
 e_put:

diff --git a/drivers/virt/coco/sev-guest/sev-guest.c b/drivers/virt/coco/sev-guest/sev-guest.c
index 57089c092d8a347c56099a05c9111516cf498f6f..2fac7f712158330f41050d1c22c21d2808d7cf75 100644 (file)
--- a/drivers/virt/coco/sev-guest/sev-guest.c
+++ b/drivers/virt/coco/sev-guest/sev-guest.c
@@ -324,7 +324,8 @@ static int handle_guest_request(struct snp_guest_dev *snp_dev, u64 exit_code, in
                                u8 type, void *req_buf, size_t req_sz, void *resp_buf,
                                u32 resp_sz, __u64 *fw_err)
 {
-       unsigned long err;
+       unsigned long err, override_err = 0;
+       unsigned int override_npages = 0;
        u64 seqno;
        int rc;
 
@@ -340,6 +341,7 @@ static int handle_guest_request(struct snp_guest_dev *snp_dev, u64 exit_code, in
        if (rc)
                return rc;
 
+retry_request:
        /*
         * Call firmware to process the request. In this function the encrypted
         * message enters shared memory with the host. So after this call the
@@ -348,17 +350,24 @@ static int handle_guest_request(struct snp_guest_dev *snp_dev, u64 exit_code, in
         */
        rc = snp_issue_guest_request(exit_code, &snp_dev->input, &err);
 
-       /*
-        * If the extended guest request fails due to having too small of a
-        * certificate data buffer, retry the same guest request without the
-        * extended data request in order to increment the sequence number
-        * and thus avoid IV reuse.
-        */
-       if (exit_code == SVM_VMGEXIT_EXT_GUEST_REQUEST &&
-           err == SNP_GUEST_REQ_INVALID_LEN) {
-               const unsigned int certs_npages = snp_dev->input.data_npages;
+       switch (rc) {
+       case -ENOSPC:
+               /*
+                * If the extended guest request fails due to having too
+                * small of a certificate data buffer, retry the same
+                * guest request without the extended data request in
+                * order to increment the sequence number and thus avoid
+                * IV reuse.
+                */
+               override_npages = snp_dev->input.data_npages;
+               exit_code       = SVM_VMGEXIT_GUEST_REQUEST;
 
-               exit_code = SVM_VMGEXIT_GUEST_REQUEST;
+               /*
+                * Override the error to inform callers the given extended
+                * request buffer size was too small and give the caller the
+                * required buffer size.
+                */
+               override_err    = SNP_GUEST_REQ_INVALID_LEN;
 
                /*
                 * If this call to the firmware succeeds, the sequence number can
@@ -368,15 +377,7 @@ static int handle_guest_request(struct snp_guest_dev *snp_dev, u64 exit_code, in
                 * of the VMPCK and the error code being propagated back to the
                 * user as an ioctl() return code.
                 */
-               rc = snp_issue_guest_request(exit_code, &snp_dev->input, &err);
-
-               /*
-                * Override the error to inform callers the given extended
-                * request buffer size was too small and give the caller the
-                * required buffer size.
-                */
-               err = SNP_GUEST_REQ_INVALID_LEN;
-               snp_dev->input.data_npages = certs_npages;
+               goto retry_request;
        }
 
        /*
@@ -388,7 +389,10 @@ static int handle_guest_request(struct snp_guest_dev *snp_dev, u64 exit_code, in
        snp_inc_msg_seqno(snp_dev);
 
        if (fw_err)
-               *fw_err = err;
+               *fw_err = override_err ?: err;
+
+       if (override_npages)
+               snp_dev->input.data_npages = override_npages;
 
        /*
         * If an extended guest request was issued and the supplied certificate
@@ -396,7 +400,7 @@ static int handle_guest_request(struct snp_guest_dev *snp_dev, u64 exit_code, in
         * prevent IV reuse. If the standard request was successful, return -EIO
         * back to the caller as would have originally been returned.
         */
-       if (!rc && err == SNP_GUEST_REQ_INVALID_LEN)
+       if (!rc && override_err == SNP_GUEST_REQ_INVALID_LEN)
                return -EIO;
 
        if (rc) {