]> git.baikalelectronics.ru Git - kernel.git/commitdiff
perf annotate: Set error stream of objdump process for TUI
authorNamhyung Kim <namhyung@kernel.org>
Wed, 2 Feb 2022 07:08:25 +0000 (23:08 -0800)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Sun, 6 Feb 2022 12:03:06 +0000 (09:03 -0300)
The stderr should be set to a pipe when using TUI.  Otherwise it'd
print to stdout and break TUI windows with an error message.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/20220202070828.143303-2-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/annotate.c

index 01900689dc0017a422bfaa443856b226c72d8a1e..8190a124b99d9d3ff0cb155330c60693bf2208ad 100644 (file)
@@ -2036,6 +2036,7 @@ static int symbol__disassemble(struct symbol *sym, struct annotate_args *args)
        memset(&objdump_process, 0, sizeof(objdump_process));
        objdump_process.argv = objdump_argv;
        objdump_process.out = -1;
+       objdump_process.err = -1;
        if (start_command(&objdump_process)) {
                pr_err("Failure starting to run %s\n", command);
                err = -1;