]> git.baikalelectronics.ru Git - kernel.git/commitdiff
nvme-tcp: fix data digest pointer calculation
authorVarun Prakash <varun@chelsio.com>
Mon, 25 Oct 2021 17:17:30 +0000 (22:47 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 2 Nov 2021 18:46:13 +0000 (19:46 +0100)
commit d89b9f3bbb58e9e378881209756b0723694f22ff upstream.

ddgst is of type __le32, &req->ddgst + req->offset
increases &req->ddgst by 4 * req->offset, fix this by
type casting &req->ddgst to u8 *.

Fixes: 1fcf4b8ae898 ("nvme-tcp: add NVMe over TCP host driver")
Signed-off-by: Varun Prakash <varun@chelsio.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/nvme/host/tcp.c

index 38bbbbbc6f47f9d13dbdb187e4a6f9e76f4ac0a6..ff0d06e8ebb5335959a60c4676a56dd5dcd32b16 100644 (file)
@@ -962,7 +962,7 @@ static int nvme_tcp_try_send_ddgst(struct nvme_tcp_request *req)
        int ret;
        struct msghdr msg = { .msg_flags = MSG_DONTWAIT | MSG_EOR };
        struct kvec iov = {
-               .iov_base = &req->ddgst + req->offset,
+               .iov_base = (u8 *)&req->ddgst + req->offset,
                .iov_len = NVME_TCP_DIGEST_LENGTH - req->offset
        };